Change gdextension dependencies so they're actually used, patch the SDK #31

vaporvee · 2023-06-30T16:35:52Z

vaartis commented

2023-06-30 16:35:52 +00:00

(Migrated from github.com)

This part isn't very well documented, but they changed the format of that file at some point and now it needs to be like this to pull the dependencies into the built project. Assuming this is what the export plugin does, that can probably be removed.

Also, a file in the discord SDK is missing an include that is required to build it, so patch that in in setup.py

This part isn't very well documented, but they changed the format of that file at some point and now it needs to be like this to pull the dependencies into the built project. Assuming this is what the export plugin does, that can probably be removed. Also, a file in the discord SDK is missing an include that is required to build it, so patch that in in setup.py

vaporvee commented

2023-06-30 18:05:45 +00:00

why adding this inlcude to setup.py instead of directly to types.h? Also everything builds and works so whats your issue?

why adding this inlcude to `setup.py` instead of directly to `types.h`? Also everything builds and works so whats your issue?

vaporvee commented

2023-06-30 18:07:09 +00:00

oh my mistake the dependency fix is very helpfull but weird that it all works without the fix

vaporvee commented

2023-06-30 18:08:02 +00:00

what is : "" } ?

what is `: "" }` ?

vaartis commented

2023-06-30 18:16:02 +00:00

(Migrated from github.com)

why adding this inlcude to setup.py instead of directly to types.h? Also everything builds and works so whats your issue?

Because types.h comes from the discord API zip. In the repository it's not actually unpacked. It does not build for me (on linux). I assume it works fine on windows because that's how things with stdint usually go.

what is : "" } ?

The format is apparently { "original path": "build dir path" }, but it's barely documented.

> why adding this inlcude to `setup.py` instead of directly to `types.h`? Also everything builds and works so whats your issue? Because types.h comes from the discord API zip. In the repository it's not actually unpacked. It does not build for me (on linux). I assume it works fine on windows because that's how things with stdint usually go. > what is : "" } ? The format is apparently `{ "original path": "build dir path" }`, but it's barely documented.

vaporvee commented

2023-06-30 20:01:57 +00:00

oh sorry didn't work on the plugin for quite some time thanks for the refresher 😅
But yeah linux did only build on some distros (not all) I'll test the PR real quick!

oh sorry didn't work on the plugin for quite some time thanks for the refresher 😅 But yeah linux did only build on some distros (not all) I'll test the PR real quick!

vaporvee commented

2023-06-30 20:22:49 +00:00

I'll remove the export plugin in a extra commit

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: vaporvee/discord-rpc-godot#31