vaporvee/discord-rpc-godot
1
2
Fork 0
Code Issues 1 Pull Requests 1 Actions Releases 20 Wiki Activity

Better platform detection #50

Merged
EddieDover merged 6 commits from multiplatform-building into main 2024-02-02 17:28:42 +00:00
Conversation 3 Commits 6 Files Changed 3 +13 -5
EddieDover commented 2023-12-23 14:47:38 +00:00 (Migrated from github.com)
Copy Link

The os.name for a M2 mac (not sure about the intel versions) comes back as posix, not darwin.
So, to better facilitate multi-platform building, I've switched the build.py file to use platform.
I've also added a requirements.txt file for people (like myself) that use venv and pip -r

The os.name for a M2 mac (not sure about the intel versions) comes back as posix, not darwin. So, to better facilitate multi-platform building, I've switched the build.py file to use **platform**. I've also added a requirements.txt file for people (like myself) that use **venv** and **pip -r**
EddieDover commented 2023-12-23 14:48:07 +00:00 (Migrated from github.com)
Copy Link

Sorry about the duplicate commits. I rebased but someone kept making changes to main :P

Sorry about the duplicate commits. I rebased but someone kept making changes to main :P
Pukimaa (Migrated from github.com) approved these changes 2024-01-19 22:54:51 +00:00
Pukimaa (Migrated from github.com) left a comment
Copy Link

LGTM! Really like those changes a lot, as I use a venv as well and requirements.txt is a must have for every repo that includes python imo.

LGTM! Really like those changes a lot, as I use a venv as well and requirements.txt is a must have for every repo that includes python imo.
vaporvee commented 2024-02-02 17:28:39 +00:00
Copy Link

forgot to merge that sorry!

forgot to merge that sorry!
Sign in to join this conversation.
Reviewers
No Reviewers
Pukimaa
Labels
Clear labels
bug
Something isn't working
building
Everything about building the plugin
can be for another update
not very useful for current update milestone
can't reproduce
discord's fault
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
EditorPresence
EXPERIMENTAL
enhancement
New feature or request
good first issue
Good for newcomers
important
invalid
This doesn't seem right
no response
question
Further information is requested
Todo for myself
wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
vaporvee
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: vaporvee/discord-rpc-godot#50
No description provided.
Delete Branch "multiplatform-building"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?