[Issue/Bug]: Parse error when launching a game with DiscordRPC, even with checks to disable running DiscordRPC in place. #58

New Issue

Closed

opened 2024-06-01 11:22:00 +00:00 by sourcelocation · 13 comments

sourcelocation commented 2024-06-01 11:22:00 +00:00 (Migrated from github.com)

Copy Link

What happened?

When launching the game on mobile, it crashes while parsing the file where I'm using DiscordRPC, even with checks to avoid running the code on mobile.

Version

1.3.1

Godot Version

4.2.1

Exact steps to reproduce this error

Use DiscordRPC on mobile, but don't run it. You will get this error

GDScript

func set_up():
	print(OS.get_name()) # prints: Android
	if is_mobile: return
	DiscordRPC.app_id = 1234945200032317602 # Parse Error

Godot output

No suitable library found for GDExtension: res://addons/discord-rpc-gd/bin/discord-rpc-gd.gdextension. Possible feature flags for your platform: mobile, android, etc2, astc, arm64, template, debug, template_debug

Additional information

No response

Checks

• I tried reinstalling the addon or tried to fix it myself with other methods.
• I tried restarting Discord and Godot completely.
• I did read the documentation https://vaporvee.com/docs/discord-rpc-godot/

### What happened? When launching the game on mobile, it crashes while parsing the file where I'm using DiscordRPC, even with checks to avoid running the code on mobile. ### Version 1.3.1 ### Godot Version 4.2.1 ### Exact steps to reproduce this error Use DiscordRPC on mobile, but don't run it. You will get this error  ### GDScript ```gdscript func set_up(): print(OS.get_name()) # prints: Android if is_mobile: return DiscordRPC.app_id = 1234945200032317602 # Parse Error ``` ### Godot output `No suitable library found for GDExtension: res://addons/discord-rpc-gd/bin/discord-rpc-gd.gdextension. Possible feature flags for your platform: mobile, android, etc2, astc, arm64, template, debug, template_debug` ### Additional information _No response_ ### Checks - [X] I tried reinstalling the addon or tried to fix it myself with other methods. - [X] I tried restarting Discord and Godot completely. - [X] I did read the documentation https://vaporvee.com/docs/discord-rpc-godot/

vaporvee commented 2024-06-01 11:37:50 +00:00

Copy Link

there is a function to unregister that in GDExtentionManager i think. will send you a solution when I'm at home. on web it doesnt crash never tested it on mobile tbh

there is a function to unregister that in GDExtentionManager i think. will send you a solution when I'm at home. on web it doesnt crash never tested it on mobile tbh

sourcelocation commented 2024-06-02 10:29:57 +00:00 (Migrated from github.com)

Copy Link

Thank you, will be waiting

Thank you, will be waiting

vaporvee commented 2024-07-29 20:33:45 +00:00

Copy Link

Sorry for not responding will have time next week

Sorry for not responding will have time next week

sourcelocation commented 2024-07-29 22:54:29 +00:00 (Migrated from github.com)

Copy Link

No problem, I'm still developing my game to this day.

No problem, I'm still developing my game to this day.

vaporvee commented 2024-08-08 20:05:11 +00:00

Copy Link

Try

if GDExtensionManager.is_extension_loaded("res://addons/discord-rpc-gd/bin/discord-rpc-gd.gdextension"):

before loading any part of the plugin also exclude the plugin in the export settings like the following and tell me if it helped.

I don't have the project anymore where i accomplished this but i remember GDExtensionManager is the way.

Try ```gdscript if GDExtensionManager.is_extension_loaded("res://addons/discord-rpc-gd/bin/discord-rpc-gd.gdextension"): ``` before loading any part of the plugin also exclude the plugin in the export settings like the following and tell me if it helped.  I don't have the project anymore where i accomplished this but i remember GDExtensionManager is the way.

sourcelocation commented 2024-08-09 15:20:12 +00:00 (Migrated from github.com)

Copy Link

Thank you 👍

Thank you 👍

Yolwoocle commented 2024-09-10 12:36:11 +00:00 (Migrated from github.com)

Copy Link

Try

if GDExtensionManager.is_extension_loaded("res://addons/discord-rpc-gd/bin/discord-rpc-gd.gdextension"):

before loading any part of the plugin also exclude the plugin in the export settings like the following and tell me if it helped. I don't have the project anymore where i accomplished this but i remember GDExtensionManager is the way.

This did not seem to work for me, and I still get the Identifier "DiscordRPC" not declared in the current scope error, despite writing code to avoid running lines with DiscordRPC. I know that it was mentioned in #67 that Discord rich presence is not possible, but I would love to know if there is some sort of workaround to avoid having the game crashing on mobile.

> Try > > ```gdscript > if GDExtensionManager.is_extension_loaded("res://addons/discord-rpc-gd/bin/discord-rpc-gd.gdextension"): > ``` > > before loading any part of the plugin also exclude the plugin in the export settings like the following and tell me if it helped.  I don't have the project anymore where i accomplished this but i remember GDExtensionManager is the way. This did not seem to work for me, and I still get the `Identifier "DiscordRPC" not declared in the current scope` error, despite writing code to avoid running lines with DiscordRPC. I know that it was mentioned in #67 that Discord rich presence is not possible, but I would love to know if there is some sort of workaround to avoid having the game crashing on mobile.

Yolwoocle commented 2024-09-10 12:40:12 +00:00 (Migrated from github.com)

Copy Link

Ideally, since try/catch patterns are not a thing in Godot, this plugin should avoid causing crashes on unsupported platforms.

Ideally, since try/catch patterns are not a thing in Godot, this plugin should avoid causing crashes on unsupported platforms.

vaporvee commented 2024-09-10 14:33:01 +00:00

Copy Link

the issue is this is just how godot runs gdextensions i can't change that. Is the autoload maybe still running? you should only add the node conataining a script with discord rpc when the plugin is loaded so you cant do

if GDExtensionManager.is_extension_loaded("res://addons/discord-rpc-gd/bin/discord-rpc-gd.gdextension"):
    DiscordRPC.app_id= xyz

instead you need to do

if GDExtensionManager.is_extension_loaded("res://addons/discord-rpc-gd/bin/discord-rpc-gd.gdextension"):
    add_child(your_node_with_discord_rpc_xyz)

the issue is this is just how godot runs gdextensions i can't change that. Is the autoload maybe still running? you should only add the node conataining a script with discord rpc when the plugin is loaded so you cant do ```gdscript if GDExtensionManager.is_extension_loaded("res://addons/discord-rpc-gd/bin/discord-rpc-gd.gdextension"): DiscordRPC.app_id= xyz ``` instead you need to do ```gdscript if GDExtensionManager.is_extension_loaded("res://addons/discord-rpc-gd/bin/discord-rpc-gd.gdextension"): add_child(your_node_with_discord_rpc_xyz) ```

vaporvee commented 2024-09-10 14:34:04 +00:00

Copy Link

then you maybe make a manager with the node saved and run stuff on it when its not null

then you maybe make a manager with the node saved and run stuff on it when its not null

Yolwoocle commented 2024-09-11 16:36:28 +00:00 (Migrated from github.com)

Copy Link

Okay, thank you for your answer. I ended up making a scene for the Discord rich presence, and put something like this in my main autoload, which seems to do the trick.

func is_discord_rpc_supported() -> bool:
	return game_platform == GamePlatform.PC and GDExtensionManager.is_extension_loaded("res://addons/discord-rpc-gd/bin/discord-rpc-gd.gdextension")

func _init_discord_rpc():
	if not is_discord_rpc_supported():
		return
	
	var discord_rich_presence_scene: PackedScene = load("res://scenes/integration/discord_rich_presence.tscn")
	discord_rich_presence = discord_rich_presence_scene.instantiate()
	add_child(discord_rich_presence)
	
	discord_rich_presence.initialize()

Okay, thank you for your answer. I ended up making a scene for the Discord rich presence, and put something like this in my main autoload, which seems to do the trick. ```gdscript func is_discord_rpc_supported() -> bool: return game_platform == GamePlatform.PC and GDExtensionManager.is_extension_loaded("res://addons/discord-rpc-gd/bin/discord-rpc-gd.gdextension") func _init_discord_rpc(): if not is_discord_rpc_supported(): return var discord_rich_presence_scene: PackedScene = load("res://scenes/integration/discord_rich_presence.tscn") discord_rich_presence = discord_rich_presence_scene.instantiate() add_child(discord_rich_presence) discord_rich_presence.initialize() ```

👍 1

vaporvee commented 2024-10-03 20:30:52 +00:00

Copy Link

I'll add that to the troubleshooting guide if that's okay :)

I'll add that to the troubleshooting guide if that's okay :)

👍 3

Yolwoocle commented 2024-10-03 20:33:36 +00:00 (Migrated from github.com)

Copy Link

I'll add that to the troubleshooting guide if that's okay :)

Sounds good. Feel free to use my bit of code if needed

> I'll add that to the troubleshooting guide if that's okay :) Sounds good. Feel free to use my bit of code if needed

❤️ 1

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

diklor/main

discord-social-sdk

legacy

4.0.X

1.3.1-reupload

1.3.1

1.3.0

1.2.0

1.1.0

1.0.1

1.0.0

3.2

3.1

3.0

2.4

2.3

2.2

2.1

2.0

1.5

1.4

1.3

1.2

1.1

1.0

Labels

Clear labels

bug

Something isn't working

building

Everything about building the plugin

can be for another update

not very useful for current update milestone

can't reproduce

discord's fault

documentation

Improvements or additions to documentation

duplicate

This issue or pull request already exists

EditorPresence

EXPERIMENTAL

enhancement

New feature or request

good first issue

Good for newcomers

important

invalid

This doesn't seem right

no response

question

Further information is requested

Todo for myself

wontfix

This will not be worked on

No Label

building

Milestone

No items

No Milestone

Assignees

Clear assignees

vaporvee

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: vaporvee/discord-rpc-godot#58

No description provided.