vaporvee/discord-rpc-godot
1
2
Fork 0
Code Issues 1 Pull Requests 1 Actions Releases 20 Wiki Activity

Updating Preview #9

Merged
Pukimaa merged 1 commits from updating-assets into main 2023-05-05 20:46:54 +00:00
Conversation 9 Commits 1 Files Changed 2 +109 -45
Pukimaa commented 2023-05-04 21:11:34 +00:00 (Migrated from github.com)
Copy Link
  1. Using Pomelo (new username system)
  2. Added tooltips
1. Using Pomelo (new username system) 2. Added tooltips
vaporvee commented 2023-05-05 04:56:57 +00:00
Copy Link

Can you make the contrast for the tooltips higher? Or should we leave that original?

Can you make the contrast for the tooltips higher? Or should we leave that original?
vaporvee commented 2023-05-05 09:44:23 +00:00
Copy Link

also shouldn't they overlap with "Playing a game"?

also shouldn't they overlap with "Playing a game"?
Pukimaa commented 2023-05-05 14:37:46 +00:00 (Migrated from github.com)
Copy Link

I would leave the color as is and I just pushed it up so everything is visible. I also wanted to change the user.

I would leave the color as is and I just pushed it up so everything is visible. I also wanted to change the user.
vaporvee commented 2023-05-05 14:47:41 +00:00
Copy Link

overlapping shows that its nothing that will be constant visible thats also my issue with the contrast

overlapping shows that its nothing that will be constant visible thats also my issue with the contrast
vaporvee commented 2023-05-05 14:49:38 +00:00
Copy Link

also that would be more like the orignal screenshot

also that would be more like the orignal screenshot
Pukimaa commented 2023-05-05 19:30:31 +00:00 (Migrated from github.com)
Copy Link

Updated @vaporvee 👍

Updated @vaporvee 👍
vaporvee commented 2023-05-05 20:29:50 +00:00
Copy Link

perfect could you quickly squash the commits?

perfect could you quickly squash the commits?
Pukimaa commented 2023-05-05 20:45:52 +00:00 (Migrated from github.com)
Copy Link

perfect could you quickly squash the commits?

Done!

> perfect could you quickly squash the commits? Done!
vaporvee approved these changes 2023-05-05 20:46:02 +00:00
vaporvee left a comment
Copy Link

lgtm

lgtm
Sign in to join this conversation.
Reviewers
No Reviewers
vaporvee
Labels
Clear labels
bug
Something isn't working
building
Everything about building the plugin
can be for another update
not very useful for current update milestone
can't reproduce
discord's fault
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
EditorPresence
EXPERIMENTAL
enhancement
New feature or request
good first issue
Good for newcomers
important
invalid
This doesn't seem right
no response
question
Further information is requested
Todo for myself
wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
vaporvee
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: vaporvee/discord-rpc-godot#9
No description provided.
Delete Branch "updating-assets"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?