vaporvee/discord-rpc-godot
1
2
Fork 0
Code Issues 1 Pull Requests 1 Actions Releases 20 Wiki Activity

Make macos version work (testes on m1 at least) #53

Merged
vaartis merged 1 commits from macos-fixes into main 2024-02-27 06:14:04 +00:00
Conversation 7 Commits 1 Files Changed 3 +18 -10
vaartis commented 2024-02-25 13:49:33 +00:00 (Migrated from github.com)
Copy Link
  1. Change name of discord's library to libdiscord_game_sdk, so it links properly
  2. Change its install name with install_name_tool to use @loader_path instead of @rpath, that one's on discord's side, it should really have been loader_path from the beginning (rpath means look at where the binary is started from, loader_path means look at where the library is)
  3. Combine the aarch and x86 library into one, again no idea why discord does not do this themselves
1. Change name of discord's library to libdiscord_game_sdk, so it links properly 2. Change its install name with install_name_tool to use @loader_path instead of @rpath, that one's on discord's side, it should really have been loader_path from the beginning (rpath means look at where the binary is started from, loader_path means look at where the library is) 3. Combine the aarch and x86 library into one, again no idea why discord does not do this themselves
🎉 1 🚀 1
vaporvee reviewed 2024-02-25 13:49:33 +00:00
vaporvee commented 2024-02-25 14:18:45 +00:00
Copy Link

okay so we got it working on intel let us test it on m1

okay so we got it working on intel let us test it on m1
vaporvee commented 2024-02-25 14:22:09 +00:00
Copy Link

@EddieDover

@EddieDover
vaporvee commented 2024-02-25 14:57:55 +00:00
Copy Link

this worked on apple silicon so far wow! thank you :) will merge it when we are able to test it on intel in a day and will release it

this worked on apple silicon so far wow! thank you :) will merge it when we are able to test it on intel in a day and will release it
EddieDover commented 2024-02-25 14:57:57 +00:00 (Migrated from github.com)
Copy Link

I can confirm this builds and works perfectly on my M2 mac.

I can confirm this builds and works perfectly on my M2 mac.
EddieDover commented 2024-02-27 03:45:22 +00:00 (Migrated from github.com)
Copy Link

I can also confirm this builds and works perfectly on an Intel.

I wholeheartedly approve this PR.

I can also confirm this builds and works perfectly on an Intel. I wholeheartedly approve this PR.
vaporvee commented 2024-02-27 06:13:56 +00:00
Copy Link

will make a release soon! :)

will make a release soon! :)
Sign in to join this conversation.
Reviewers
No Reviewers
vaporvee
Labels
Clear labels
bug
Something isn't working
building
Everything about building the plugin
can be for another update
not very useful for current update milestone
can't reproduce
discord's fault
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
EditorPresence
EXPERIMENTAL
enhancement
New feature or request
good first issue
Good for newcomers
important
invalid
This doesn't seem right
no response
question
Further information is requested
Todo for myself
wontfix
This will not be worked on
No Label
building
enhancement
important
Milestone
No items
No Milestone
Assignees
Clear assignees
vaporvee
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: vaporvee/discord-rpc-godot#53
No description provided.
Delete Branch "macos-fixes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?