vaporvee/discord-rpc-godot
1
2
Fork 0
Code Issues 1 Pull Requests 1 Actions Releases 20 Wiki Activity

Fix: Editor crash when creating new scene #81

Merged
SmiterG merged 1 commits from crash_fix into main 2025-07-10 11:21:02 +00:00
Conversation 3 Commits 1 Files Changed 1 +31 -5
SmiterG commented 2025-06-09 20:06:15 +00:00 (Migrated from github.com)
Copy Link

This PR fixes an editor crash issue when creating new scenes.

Correction Details:

  • Added null pointer check for get_edited_scene_root().
  • Handles the case of new unsaved scenes.

Fixes #79

This PR fixes an editor crash issue when creating new scenes. **Correction Details:** - Added null pointer check for get_edited_scene_root(). - Handles the case of new unsaved scenes. Fixes #79
PedroPLopes1 commented 2025-06-09 20:13:51 +00:00 (Migrated from github.com)
Copy Link

indoso

indoso
PedroPLopes1 commented 2025-06-09 22:01:29 +00:00 (Migrated from github.com)
Copy Link

meu novo pull request ✔️✔️

meu novo pull request ✔️✔️
👀 2
vaporvee commented 2025-07-10 11:21:00 +00:00
Copy Link

yeah that was it. i figured using the scene_change event would fix it but not having any nullptr exceptions in the first place is even cooler. sorry for abandoning the plugin for so long

yeah that was it. i figured using the scene_change event would fix it but not having any nullptr exceptions in the first place is even cooler. sorry for abandoning the plugin for so long
❤️ 1
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
building
Everything about building the plugin
can be for another update
not very useful for current update milestone
can't reproduce
discord's fault
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
EditorPresence
EXPERIMENTAL
enhancement
New feature or request
good first issue
Good for newcomers
important
invalid
This doesn't seem right
no response
question
Further information is requested
Todo for myself
wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
vaporvee
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: vaporvee/discord-rpc-godot#81
No description provided.
Delete Branch "crash_fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?